Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, drop old Go versions #787

Closed
wants to merge 4 commits into from

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Sep 6, 2023

Updated jacobsa-crypto which also pulls in the latest versions of the golang.org/x/ packages.


.github: drop unsupported Go versions

According to https://go.dev/doc/devel/release#policy each major Go release is
supported until there are two newer major releases. For example, Go 1.5 was
supported until the Go 1.7 release, and Go 1.6 was supported until the Go 1.8
release. Older releases are not receiving security updates.

Upcoming dependency updates to golang exp packages use newer features like
unsafe.Slice and therefore do not build correctly against Go < 1.19.x.

Drop the older versions and add the newer versions to the ci.

@paralin paralin changed the title Update /x/crypto, /x/sys/, /x/term, jacobsa-crypto Update /x/crypto, /x/sys/, /x/term, jacobsa-crypto, drop old Go versions from CI Sep 6, 2023
@paralin paralin changed the title Update /x/crypto, /x/sys/, /x/term, jacobsa-crypto, drop old Go versions from CI Update /x/crypto, /x/sys/, /x/term, jacobsa-crypto, drop old Go versions Sep 6, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
According to https://go.dev/doc/devel/release#policy each major Go release is
supported until there are two newer major releases. For example, Go 1.5 was
supported until the Go 1.7 release, and Go 1.6 was supported until the Go 1.8
release. Older releases are not receiving security updates.

Upcoming dependency updates to golang exp packages use newer features like
unsafe.Slice and therefore do not build correctly against Go < 1.19.x.

Drop the older versions and add the newer versions to the ci.

Signed-off-by: Christian Stewart <[email protected]>
@paralin
Copy link
Contributor Author

paralin commented Oct 16, 2023

@rfjakob Fixed your comment.

@paralin paralin requested a review from rfjakob October 16, 2023 19:12
Updated jacobsa-crypto which also pulls in the latest versions of the
golang.org/x/ packages.

Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
@paralin paralin changed the title Update /x/crypto, /x/sys/, /x/term, jacobsa-crypto, drop old Go versions Update dependencies, drop old Go versions Oct 16, 2023
@rfjakob
Copy link
Owner

rfjakob commented Oct 29, 2023

Merged as 5da40e7, thanks!

@rfjakob rfjakob closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants